This repository has been archived by the owner on Nov 4, 2024. It is now read-only.
fix: Fix iOS redundant payment error #4163
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
LEARNER-9999
julianajlk
approved these changes
May 20, 2024
There was a problem hiding this comment.
LGTM assuming the receipt response will always contain original_purchase_date_ms attribute, might be worth adding try/except on parse_ios_response()
Quick question - on the tests, is there a reason you've added original_purchase_date_ms in the original_test_id purchase but not on the other 2 examples other than the fact that it uses the latest?
|
@julianajlk Apple is sending this attribute with every request so its safe to assume this, otherwise its good to throw error and tell mobile client we couldn't process request successfully. On your question, I added it in valid case because if condition will break because of product_id mismatch in other two cases. |
jawad-khan
changed the title
jawad-khan
changed the title
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
LEARNER-9999
⛔️ MAIN BRANCH WARNING! 2U EMPLOYEES must make branches against the 2u/main BRANCH
⛔️ DEPRECATION WARNING
This repository is deprecated and in maintainence-only operation while we work on a replacement, please see this announcement for more information.
Although we have stopped integrating new contributions, we always appreciate security disclosures and patches sent to [email protected]
Anyone internally merging to this repository is expected to release and monitor their changes; if you are not able to do this DO NOT MERGE, please coordinate with someone who can to ensure that the changes are released.
Required Testing
(^ We can remove that manual check once REV-2624 is done and the corresponding e2e test runs again)
Description
iOS users are facing issue where they can't enroll into a course after payment. This is happening to some users because of date mismatch in iOS receipt. This fix has changed date matching attribute from 'receipt_creation_date_ms' to original_purchase_date_ms' which is the correct way to match transaction.
.
Useful information to include:
Supporting information
Jira Ticket: https://2u-internal.atlassian.net/browse/LEARNER-9999
Testing instructions
Please provide detailed step-by-step instructions for testing this change; how did YOU test this change?
Other information
Include anything else that will help reviewers and consumers understand the change.